Uploaded image for project: 'BoxGrinder Build'
  1. BoxGrinder Build
  2. BGBUILD-339

existing rpm package with the name containing '+' considered as an invalid name

    Details

    • Steps to Reproduce:
      Hide

      1) configure appl, add "compat-libstdc++-33" package name in
      2) createrepo in local, also add "compat-libstdc++-33"
      3) boxgrinder-build test-vmware.appl -p vmware

      Show
      1) configure appl, add "compat-libstdc++-33" package name in 2) createrepo in local, also add "compat-libstdc++-33" 3) boxgrinder-build test-vmware.appl -p vmware
    • Bugzilla Update:
      Perform

      Description

      My custom appliance need this rpm package: compat-libstdc++-33-3.2.3-69.el6.x86_64.rpm
      I noted this rpm in appl as "compat-libstdc++-33".
      However, boxgrinder always notify me that it could not find this package:

      FATAL – : RuntimeError: Package compat-libstdc++-33 for test-vmware appliance not found in repositories. Please check package names in appliance definition file.

      I went through the source code, and found one string-matching condition is quite strange:
      "invalid_names" function in "boxgrinder-build-0.9.8/lib/boxgrinder-build/plugins/os/rpm-based/rpm-dependency-validator.rb"

      if package.size > 0 and name.match( /^#

      {package.gsub(/[\+]/, '\\+')}

      / )
      found = true
      end

      when "compat-libstdc+-33", the package value = "compat-libstdc-33", the same. But this regex matching rule will delete '' in package, makes name and package not matched.
      I think it is a bug on handling package name matching.

      can we make the package name matching not so strict as now?
      If other strange rpm name comes, still will cause new bugs.

      If you have any comments, please let me know.
      Thanks & Best wishes,
      Henry

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                msavy Marc Savy
                Reporter:
                henryshuang Henry Huang
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: