Application Server 7
  1. Application Server 7
  2. AS7-2909

AS7 testsuite - maven.test.failure.ignore vs. surefire.test.failure.ignore

    Details

    • Similar Issues:
      Show 10 results 

      Description

      I have problem with AS7 TS internal surefire.test.failure.ignore property to ignore tests failures. Ignoring failed tests can be useful for code coverage or when you are building unstable version of AS7. With this property we are adding requirements for users because they will need to search for all properties and can't rely on standard Maven knowledge.

      Is there any hidden motivation for surefire.test.failure.ignore property? I can't recall any.

      Current command:
      ./tools/maven/bin/mvn -e -s tools/maven/conf/settings.xml install -Dts.smoke -Dmaven.test.failure.ignore=true -Dsurefire.test.failure.ignore=true
      Goal:
      ./tools/maven/bin/mvn -e -s tools/maven/conf/settings.xml install -Dts.smoke -Dmaven.test.failure.ignore=true
      Suggestion:
      Replace surefire.test.failure.ignore property with standard maven.test.failure.ignore

      Links:
      https://github.com/jbossas/jboss-as/blob/master/testsuite/pom.xml#L114
      http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#testFailureIgnore

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Jason Greene added a comment -

            This issue is being relocated to 7.1.2 so that 7.1.1 only contains criticals, blockers, and EAP LA issues (which are probably not yet at the right status, or need an extra triage pass).

            If these issues are completed in a 7.1.1 timeframe please change the fix version. Although if you forget I will bulk correct.

            Show
            Jason Greene added a comment - This issue is being relocated to 7.1.2 so that 7.1.1 only contains criticals, blockers, and EAP LA issues (which are probably not yet at the right status, or need an extra triage pass). If these issues are completed in a 7.1.1 timeframe please change the fix version. Although if you forget I will bulk correct.
            Hide
            Ondrej Zizka added a comment -

            surefire.test.failure.ignore

            is AS7 specific, and will be removed.

            Show
            Ondrej Zizka added a comment - surefire.test.failure.ignore is AS7 specific, and will be removed.
            Show
            Ondrej Zizka added a comment - Merged in upstream, https://github.com/jbossas/jboss-as/commit/2cf45a73c0c8494897ae00357595aae740e3d27c

              People

              • Assignee:
                Ondrej Zizka
                Reporter:
                Rostislav Svoboda
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development