Uploaded image for project: 'Application Server 7'
  1. Application Server 7
  2. AS7-1001

WSDeploymentActivator uses a Phase priority which isn't listed in org.jboss.as.server.deployment.Phase

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 7.0.0.CR1
    • Component/s: Web Services
    • Labels:
      None
    • Environment:

      AS7 upstream (Jun 12 2011)

      Description

      WSDeploymentActivator has code like this for registering deployment unit processors:

      static void activate(final BootOperationContext updateContext) {
              int priority = Phase.INSTALL_WAR_METADATA + 10;
      ...
             
              updateContext.addDeploymentProcessor(Phase.INSTALL, priority++, new WSTypeDeploymentProcessor());
              updateContext.addDeploymentProcessor(Phase.INSTALL, priority++, new WSModelDeploymentProcessor());
      ...
              addDeploymentProcessors(updateContext, priority);
          }
      
      

      Notice that the Phase priorities have been localized to this WS code. Localizing the Phase priority to the WS code can lead to issues where some other subsystem or even WS might end up adding a duplicate Phase priority in org.jboss.as.server.deployment.Phase. The org.jboss.as.server.deployment.Phase is supposed to act as a central location where the phase priorities are listed so that such situations can be avoided.

      Moving the phase priorities out of WSDeploymentActivator (and other such classes, if there are any more) is recommended.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                ropalka Richard Opalka
                Reporter:
                jaikiran Jaikiran Pai
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: