Uploaded image for project: 'Arquillian'
  1. Arquillian
  2. ARQ-49

Arquillian depends upon ShrinkWrap internals

        Details

          Description

          Caught that a few Arquillian classes are directly depending upon ShrinkWrap internals, for which we cannot provide guarantee of consistency between releases.

          [alr@localhost trunk]$ egrep 'shrinkwrap.impl' -R . |grep .java
          ./demo/src/test/java/com/acme/cdi/InjectionTestCase.java:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;
          ./demo/src/test/java/com/acme/cdi/.svn/text-base/InjectionTestCase.java.svn-base:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;
          ./impl-base/src/main/java/org/jboss/arquillian/impl/ArquillianDeploymentAppender.java: Package.getPackage("org.jboss.shrinkwrap.impl.base"),
          ./impl-base/src/main/java/org/jboss/arquillian/impl/.svn/text-base/ArquillianDeploymentAppender.java.svn-base: Package.getPackage("org.jboss.shrinkwrap.impl.base"),
          ./junit/src/main/java/org/jboss/arquillian/junit/JUnitTestRunner.java:import org.jboss.shrinkwrap.impl.base.Validate;
          ./junit/src/main/java/org/jboss/arquillian/junit/.svn/text-base/JUnitTestRunner.java.svn-base:import org.jboss.shrinkwrap.impl.base.Validate;
          ./testng/src/main/java/org/jboss/arquillian/testng/TestNGTestRunner.java:import org.jboss.shrinkwrap.impl.base.Validate;
          ./testng/src/main/java/org/jboss/arquillian/testng/.svn/text-base/TestNGTestRunner.java.svn-base:import org.jboss.shrinkwrap.impl.base.Validate;
          ./demo-testng/src/test/java/com/acme/cdi/InjectionTestCase.java:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;
          ./demo-testng/src/test/java/com/acme/cdi/.svn/text-base/InjectionTestCase.java.svn-base:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;

          Likely we'll want to evaluate these dependencies and instead move to API-only (for compile time, runtime requiring ShrinkWrap impls in "test" scope).

            Gliffy Diagrams

              Issue Links

              is blocked by

              Component Upgrade - A task tracking an update to a bundled component ARQ-607 Upgrade to ShrinkWrap 1.0.0-beta-6

              • Major - A request that should be considered seriously but is not a show stopper.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                Only impl dep remaining is ToolingDeploymentFormatter:

                fgrep 'shrinkwrap.impl' -R . 
                ./container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/deployment/tool/ToolingDeploymentFormatter.java:import org.jboss.shrinkwrap.impl.base.asset.ArchiveAsset;
                		 
                ./container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/deployment/tool/ToolingDeploymentFormatter.java:import org.jboss.shrinkwrap.impl.base.asset.ClassAsset;
                		 
                ./container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/deployment/tool/ToolingDeploymentFormatter.java:import org.jboss.shrinkwrap.impl.base.asset.ClassLoaderAsset;

                It attempts to export a xml format for Tooling to pick up on, needs the Asset types to show where Assets are picked up from

                Show
                aslak Aslak Knutsen added a comment - Only impl dep remaining is ToolingDeploymentFormatter: fgrep 'shrinkwrap.impl' -R . ./container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/deployment/tool/ToolingDeploymentFormatter.java:import org.jboss.shrinkwrap.impl.base.asset.ArchiveAsset; ./container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/deployment/tool/ToolingDeploymentFormatter.java:import org.jboss.shrinkwrap.impl.base.asset.ClassAsset; ./container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/deployment/tool/ToolingDeploymentFormatter.java:import org.jboss.shrinkwrap.impl.base.asset.ClassLoaderAsset; It attempts to export a xml format for Tooling to pick up on, needs the Asset types to show where Assets are picked up from
                Hide
                Permalink
                edewit Erik Jan de Wit added a comment -

                This ToolingDeploymentFormatter is no longer used, it's only referenced from the test case

                Show
                edewit Erik Jan de Wit added a comment - This ToolingDeploymentFormatter is no longer used, it's only referenced from the test case
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                ToolingDeploymentFormatter is a class that should help JBoss Tools to do some sort of Deployment view during testing, but it was never really followed up on further.

                Show
                aslak Aslak Knutsen added a comment - ToolingDeploymentFormatter is a class that should help JBoss Tools to do some sort of Deployment view during testing, but it was never really followed up on further.
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                pushed upstream

                Show
                aslak Aslak Knutsen added a comment - pushed upstream

                  People

                  • Assignee:
                    aslak Aslak Knutsen
                    Reporter:
                    alrubinger Andrew Rubinger
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development