Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Blocker
-
Resolution: Done
-
Affects Version/s: 1.0.0.Alpha5
-
Fix Version/s: 1.0.0.CR2
-
Component/s: Base Implementation
-
Labels:None
-
Environment:Arquillian/OpenEJB combination from 1.0.0-SNAPSHOT
-
Git Pull Request:
Description
After today's build of SNAPSHOT, the Before and After methods of tests are no longer execcuted.
Gliffy Diagrams
Issue Links
- relates to
-
ARQ-1070
Arquillian JUnit Standalone doesn't execute methods annotated by @Before annotation
-
- Open
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
I apologize for re-opening this issue many times in a day, but it's been difficult tracking down what the problem is.
The actual problem is when an assert fails in a test, the After events never get fired. This is incorrect; regardless of the outcome of a test, all after test events need to be fired and processed.
David Allen
added a comment - I apologize for re-opening this issue many times in a day, but it's been difficult tracking down what the problem is.
The actual problem is when an assert fails in a test, the After events never get fired. This is incorrect; regardless of the outcome of a test, all after test events need to be fired and processed. The above test case always asserts that Before and After were not called. I'm not really sure what the test is testing, but it definitely excludes all the before/after methods. Is there a way to change this test so that it does include the before/after methods?
David Allen
added a comment - The above test case always asserts that Before and After were not called. I'm not really sure what the test is testing, but it definitely excludes all the before/after methods. Is there a way to change this test so that it does include the before/after methods? right, before/after is not executed because your executing as a client. 
Aslak Knutsen
added a comment - right, before/after is not executed because your executing as a client.
This problem with After methods being skipped is limited to tests which fail, not tests which are in error (throw some arbitrary exception).
David Allen
added a comment - This problem with After methods being skipped is limited to tests which fail, not tests which are in error (throw some arbitrary exception). pushed upstream, standalone embedded containers updated to not add the Before/After Observers
Aslak Knutsen
added a comment - pushed upstream, standalone embedded containers updated to not add the Before/After Observers 
Modified the OpenEJBConfigTestCase to also check the execution of the before method before the test executes on this branch: git://github.com/drallen/arquillian.git.