Details
-
Type:
Feature Request
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: 1.0.0.Alpha4
-
Fix Version/s: 1.0.0.Alpha5
-
Component/s: Base Implementation
-
Labels:None
Description
For better consistent naming, we should rename the API annotations:
- @Run(RunModeType) = @RunAsClient
- InContainer is extracted from @Deployment(testable) and only possible to override with AS_CLIENT
- @Expected = @ShouldThrowException
- @Target = @TargetsContainer("x")
- Clearify meaning
- @DeploymentTarget = @OperateOnDeployment
- Clearify that this test will operate within the context of the @Deployment
public class TestClass
|
{
|
|
|
@Deployment(name = "dep", testable=false) @ShouldThrowException(Exception.class) @TargetsContainer("x")
|
public JavaArchive create() {}
|
|
|
container x{
|
deployment dep{
|
|
|
@Test @RunAsClient @OperateOnDeployment("dep")
|
public void shouldBe() {}
|
|
|
container x{
|
|
@Test @OperateOnContainer("x")
|
public void shouldBe() {}
|
|
}
|
Gliffy Diagrams
Issue Links
- is related to
-
ARQ-390
Add annotation @OperateOnContainer
-
- Open
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Other points:
- @Deployment.startup = @Deployment.managed | @Deployment.manual
- If Arquillian should handle deploy and undeploy
- @Deployment.testable = ?
- If the deployment should be enriched for in-container testing
Show
Aslak Knutsen
added a comment - - edited Other points:
@Deployment.startup = @Deployment.managed | @Deployment.manual
If Arquillian should handle deploy and undeploy
@Deployment.testable = ?
If the deployment should be enriched for in-container testing
Aslak Knutsen
added a comment - - edited Other points:
@Deployment.startup = @Deployment.managed | @Deployment.manual
If Arquillian should handle deploy and undeploy
@Deployment.testable = ?
If the deployment should be enriched for in-container testing
@Deployment.startup renamed managed, to avoid changing boolean logic.
@Protocol renamed @OverProtocol
|
|
@Deployment @TargetsContainer("active-1") @ShouldThrowException(Exception.class)
|
public void WebArchive myFailingComponent()
|
{
|
return ShrinkWrap.create(WebArchive.class);
|
}
|
|
|
@Deployment(name = "app1") @TargetsContainer("active-1") @OverProtocol("Servlet 3.0")
|
public void WebArchive myComponent()
|
{
|
return ShrinkWrap.create(WebArchive.class);
|
}
|
|
|
@Test @OperateOnDeployment("app1")
|
public void shouldDoX(MyComponent x)
|
{
|
// assert x
|
}
|
|
|
@Test @OperateOnDeployment("app1") @RunAsClient
|
public void shouldDoX(MyComponent x)
|
{
|
// assert x
|
}
|
|
Show
Aslak Knutsen
added a comment - - edited @Deployment.startup renamed managed, to avoid changing boolean logic.
@Protocol renamed @OverProtocol
@Deployment @TargetsContainer("active-1") @ShouldThrowException(Exception.class)
public void WebArchive myFailingComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
@Deployment(name = "app1") @TargetsContainer("active-1") @OverProtocol("Servlet 3.0")
public void WebArchive myComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
@Test @OperateOnDeployment("app1")
public void shouldDoX(MyComponent x)
{
// assert x
}
@Test @OperateOnDeployment("app1") @RunAsClient
public void shouldDoX(MyComponent x)
{
// assert x
}
Aslak Knutsen
added a comment - - edited @Deployment.startup renamed managed, to avoid changing boolean logic.
@Protocol renamed @OverProtocol
@Deployment @TargetsContainer("active-1") @ShouldThrowException(Exception.class)
public void WebArchive myFailingComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
@Deployment(name = "app1") @TargetsContainer("active-1") @OverProtocol("Servlet 3.0")
public void WebArchive myComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
@Test @OperateOnDeployment("app1")
public void shouldDoX(MyComponent x)
{
// assert x
}
@Test @OperateOnDeployment("app1") @RunAsClient
public void shouldDoX(MyComponent x)
{
// assert x
}
pushed upstream master
Show
Aslak Knutsen
added a comment - pushed upstream master
Aslak Knutsen
added a comment - pushed upstream master 
Reviewed, discussed in IRC w/ Aslak, and +1 from me.