Uploaded image for project: 'Arquillian'
  1. Arquillian
  2. ARQ-168

Validation on container configuration properties

        Details

          Description

          The container needs to ensure that the user has supplied sane configuration values, or else risk blowing up in weird and unpredictable ways. Rather than doing these laborious checks manually (and possibly only partially), A simple validation should be used to enforce the values fall with a value range or adhere to a required syntax.

          e.g.

          Type Checks, Int, String, File
          Checks: File exists, Create File etc..

            Gliffy Diagrams

              Issue Links

              incorporates

              Bug - A problem which impairs or prevents the functions of the product. ARQ-212 Create export directory if it doesn't exist

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed
              relates to

              Feature Request - A new feature of the product, which has yet to be developed. ARQ-311 Add runtime ConfigurationException for use in DeployableContainer#setup()

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. ARQ-281 NPE when JBOSS_HOME isn't set

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                dan.j.allen Dan Allen added a comment -

                Adding concept patch. We need to think about what libraries we are going to bleed onto embedded containers.

                Show
                dan.j.allen Dan Allen added a comment - Adding concept patch. We need to think about what libraries we are going to bleed onto embedded containers.
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                I'm very sceptical to external dependencies in Arquillian. It needs packaging for remote containers and how does it effect the containers. All containers in all versions. It's hard enough to get things to run across all containers, depending on external 'uncontrollable' libraries won't help.

                Show
                aslak Aslak Knutsen added a comment - I'm very sceptical to external dependencies in Arquillian. It needs packaging for remote containers and how does it effect the containers. All containers in all versions. It's hard enough to get things to run across all containers, depending on external 'uncontrollable' libraries won't help.
                Hide
                Permalink
                dan.j.allen Dan Allen added a comment -

                I heed your concern, as we don't want to make things more difficult than they already are. However, I think that this validation can occur on the client side, as Arquillian is loading. Plus, it's just a syntactical check to make sure that values are reasonable. The annotations themselves are harmless wherever they travel (though I don't think container configurations are packaged anyway).

                I should also mention that it's important for us to advocate Bean Validation

                Show
                dan.j.allen Dan Allen added a comment - I heed your concern, as we don't want to make things more difficult than they already are. However, I think that this validation can occur on the client side, as Arquillian is loading. Plus, it's just a syntactical check to make sure that values are reasonable. The annotations themselves are harmless wherever they travel (though I don't think container configurations are packaged anyway). I should also mention that it's important for us to advocate Bean Validation
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                ARQ-212 directory creation should be moved out into the Configuration module when it has the support needed.

                Show
                aslak Aslak Knutsen added a comment - ARQ-212 directory creation should be moved out into the Configuration module when it has the support needed.
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                related forum post: http://community.jboss.org/message/557447
                configuration error messages

                Show
                aslak Aslak Knutsen added a comment - related forum post: http://community.jboss.org/message/557447 configuration error messages
                Hide
                Permalink
                kpiwko Karel Piwko added a comment -

                Working tree at https://github.com/kpiwko/arquillian/tree/ARQ-281

                Show
                kpiwko Karel Piwko added a comment - Working tree at https://github.com/kpiwko/arquillian/tree/ARQ-281
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                pushed to next

                Show
                aslak Aslak Knutsen added a comment - pushed to next

                  People

                  • Assignee:
                    kpiwko Karel Piwko
                    Reporter:
                    dan.j.allen Dan Allen
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development