Uploaded image for project: 'Arquillian'
  1. Arquillian
  2. ARQ-148

Support EL-like expressions for sysprops and env variables in arquillian.xml

    Details

    • Type: Feature Request
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.0.0.CR5
    • Component/s: Configuration
    • Labels:
      None

      Description

      Likely we might need to rely on configuration available from the system or environment, so support usage like:

      <tag>$

      {jboss.home}

      </tag>
      <tag>$

      {env.jboss.home}

      </tag>

      ...inside arquillian.xml

        Gliffy Diagrams

          Activity

          Hide
          rbattenfeld Ralf Battenfeld added a comment -

          Hi Andrew, you can drop me a message in the forum or other channels for further actions as required.

          Show
          rbattenfeld Ralf Battenfeld added a comment - Hi Andrew, you can drop me a message in the forum or other channels for further actions as required.
          Hide
          aslak Aslak Knutsen added a comment -

          pushed upstream

          Show
          aslak Aslak Knutsen added a comment - pushed upstream
          Hide
          rachmato Richard Achmatowicz added a comment -

          Where can I find this change? I'm pulling in Arquillian 1.0.0.Final-SNAPSHOT and the change is not getting picked up:

          > mvn dependency:tree
          [INFO] org.jboss.as.test.clustering:my-arquillian-testsuite:jar:1.0-SNAPSHOT
          [INFO] +- org.jboss.spec.javax.servlet:jboss-servlet-api_3.0_spec:jar:1.0.0.Final:provided
          [INFO] +- org.jboss.arquillian.junit:arquillian-junit-container:jar:1.0.0.Final-SNAPSHOT:compile
          [INFO] | +- org.jboss.arquillian.junit:arquillian-junit-core:jar:1.0.0.Final-SNAPSHOT:compile
          [INFO] | +- org.jboss.arquillian.test:arquillian-test-api:jar:1.0.0.Final-SNAPSHOT:compile
          [INFO] | +- org.jboss.arquillian.test:arquillian-test-spi:jar:1.0.0.Final-SNAPSHOT:compile
          [INFO] | | +- org.jboss.arquillian.core:arquillian-core-spi:jar:1.0.0.Final-SNAPSHOT:compile
          [INFO] | | - org.jboss.shrinkwrap:shrinkwrap-api:jar:1.0.0-beta-5:compile
          ...

          <container qualifier="jboss" default="false">
          <configuration>
          <property name="jbossHome">target/clustering-udp-0</property>
          <property name="javaVmArguments">$

          {ip.server.stack}</property>
          <property name="bindAddress">192.168.0.103</property>
          <property name="serverConfig">standalone.xml</property>
          <property name="startupTimeoutInSeconds">30</property>
          <property name="outputToConsole">true</properties>
          </configuration>
          </container>

          and i'm passing in <systemPropertyvariables><ip.server.stack>-Djava.net.prefer.IPv4Stack=true</ip.server.stack></systemPropertyVariables>

          Running TestSuite
          Sep 12, 2011 10:33:07 AM org.jboss.as.arquillian.container.managed.ManagedDeployableContainer startInternal
          INFO: Starting container with: [java, ${ip.server.stack}

          , -Djboss.home.dir=target/clustering-udp-1, -Dorg.jboss.boot.log.file=target/clustering-udp-1/standalone/log/boot.log, -Dlogging.configuration=file:target/clustering-udp-1/standalone/configuration/logging.properties, -Djboss.modules.dir=target/clustering-udp-1/modules, -jar, /home/nrla/maven/my-arquillian-testsuite/target/clustering-udp-1/jboss-modules.jar, -mp, target/clustering-udp-1/modules, -logmodule, org.jboss.logmanager, -jaxpmodule, javax.xml.jaxp-provider, org.jboss.as.standalone, -server-config, standalone.xml]
          Sep 12, 2011 10:33:07 AM org.jboss.remoting3.EndpointImpl <clinit>
          INFO: JBoss Remoting version 3.2.0.Beta2
          Exception in thread "main" java.lang.NoClassDefFoundError: $

          {ip/server/stack}

          Caused by: java.lang.ClassNotFoundException: $

          {ip.server.stack}
          at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
          at java.security.AccessController.doPrivileged(Native Method)
          at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
          at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
          at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
          at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
          Could not find the main class: ${ip.server.stack}

          . Program will exit.

          Show
          rachmato Richard Achmatowicz added a comment - Where can I find this change? I'm pulling in Arquillian 1.0.0.Final-SNAPSHOT and the change is not getting picked up: > mvn dependency:tree [INFO] org.jboss.as.test.clustering:my-arquillian-testsuite:jar:1.0-SNAPSHOT [INFO] +- org.jboss.spec.javax.servlet:jboss-servlet-api_3.0_spec:jar:1.0.0.Final:provided [INFO] +- org.jboss.arquillian.junit:arquillian-junit-container:jar:1.0.0.Final-SNAPSHOT:compile [INFO] | +- org.jboss.arquillian.junit:arquillian-junit-core:jar:1.0.0.Final-SNAPSHOT:compile [INFO] | +- org.jboss.arquillian.test:arquillian-test-api:jar:1.0.0.Final-SNAPSHOT:compile [INFO] | +- org.jboss.arquillian.test:arquillian-test-spi:jar:1.0.0.Final-SNAPSHOT:compile [INFO] | | +- org.jboss.arquillian.core:arquillian-core-spi:jar:1.0.0.Final-SNAPSHOT:compile [INFO] | | - org.jboss.shrinkwrap:shrinkwrap-api:jar:1.0.0-beta-5:compile ... <container qualifier="jboss" default="false"> <configuration> <property name="jbossHome">target/clustering-udp-0</property> <property name="javaVmArguments">$ {ip.server.stack}</property> <property name="bindAddress">192.168.0.103</property> <property name="serverConfig">standalone.xml</property> <property name="startupTimeoutInSeconds">30</property> <property name="outputToConsole">true</properties> </configuration> </container> and i'm passing in <systemPropertyvariables><ip.server.stack>-Djava.net.prefer.IPv4Stack=true</ip.server.stack></systemPropertyVariables> Running TestSuite Sep 12, 2011 10:33:07 AM org.jboss.as.arquillian.container.managed.ManagedDeployableContainer startInternal INFO: Starting container with: [java, ${ip.server.stack} , -Djboss.home.dir=target/clustering-udp-1, -Dorg.jboss.boot.log.file=target/clustering-udp-1/standalone/log/boot.log, -Dlogging.configuration= file:target/clustering-udp-1/standalone/configuration/logging.properties , -Djboss.modules.dir=target/clustering-udp-1/modules, -jar, /home/nrla/maven/my-arquillian-testsuite/target/clustering-udp-1/jboss-modules.jar, -mp, target/clustering-udp-1/modules, -logmodule, org.jboss.logmanager, -jaxpmodule, javax.xml.jaxp-provider, org.jboss.as.standalone, -server-config, standalone.xml] Sep 12, 2011 10:33:07 AM org.jboss.remoting3.EndpointImpl <clinit> INFO: JBoss Remoting version 3.2.0.Beta2 Exception in thread "main" java.lang.NoClassDefFoundError: $ {ip/server/stack} Caused by: java.lang.ClassNotFoundException: $ {ip.server.stack} at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) Could not find the main class: ${ip.server.stack} . Program will exit.
          Hide
          aslak Aslak Knutsen added a comment -

          SNAPSHOTs are currently not pushed automatically to Nexus. I'll push one as soon as I have a stable connection.

          Show
          aslak Aslak Knutsen added a comment - SNAPSHOTs are currently not pushed automatically to Nexus. I'll push one as soon as I have a stable connection.
          Hide
          aslak Aslak Knutsen added a comment -

          released, pushed upstream

          Show
          aslak Aslak Knutsen added a comment - released, pushed upstream

            People

            • Assignee:
              alrubinger Andrew Rubinger
              Reporter:
              alrubinger Andrew Rubinger
            • Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development