Status: Resolved (View Workflow)
Affects Version/s: None
Fix Version/s: 0.8.1
Git Pull Request:
Similar Issues:Show 10 results
AGPUSH-24 Add Server Side spec AGPUSH-253 Admin UI add client side validation/limit characters on textareas AGPUSH-93 Add CORS for Device Registration endpoint AGPUSH-64 Add Client Side Spec AGPUSH-324 Java Clients running against OpenShift Push Server might hit SSL handshake exception AGPUSH-581 Implement server-side stats/reporting module AGPUSH-326 Bad User Agent ID throws error AGPUSH-282 AdminUI: Allow to add user AGPUSH-343 Add Access-Control-Max-Age to CORS preflight headers AGPUSH-480 Validate submitted GoogleKey
Add server side validation to avoid persistence exceptions.
eg: Trying to register an installation with long name results to javax.persistence.PersistenceException: org.hibernate.exception.DataException: Value too long for column "DEVICETOKEN VARCHAR(255) SELECTIVITY 100"
This happens for almost all the basic operations like Push App registration, Variant registration and installation registrations.
In addition the WS responses do not contain information about the bad request causes. So in order to order to understand what went wrong, someone has to check the server side logs.
if (androidVariant.getGoogleKey() == null)
It would be a better approach to remove snippets like the above one, to add Bean Validation checks and fill the response entity with a Map of ConstraintViolation property paths (bean root class) and messages.
If you believe that this issue is better described as a feature request, feel free to modify it.