Uploaded image for project: 'AeroGear'
  1. AeroGear
  2. AEROGEAR-6124

Refactor Metrics collection to be deterministic and complete

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Done
    • Major
    • None
    • None
    • None
    • None

    Description

      MetricsCollector misbehaves when all VariantMetricInformation are processed before all BatchLoaded or AllBatchesLoaded events are de-queued.

      In that case, following checks are never performed: totalBatches == servedBatches and serverVariants == totalVariants.

      In that case, VariantCompleted and PushMessageCompleted events are never fired and PushMessageInformation#servedVariants counter is never equal to PushMessageInformation#totalVariants (which is why UI still shows message is Pending).

      There are two solutions:

      1) -schedule (or somehow else trigger) collector of BatchLoaded / AllBatchesLoaded events,-

      2) refactor metric collection logic so that it is triggered externally in cycles until everything is processed

      • this involves new TriggerMetricCollectionQueue that is used to store a "request for metrics processing"
      • will allow us to update metrics more efficiently since one update cycle will cover not only several BatchLoaded events but also several VariantMetricInformation events

      See diagram for more clarity: https://docs.google.com/drawings/d/12cUrYf7ACLYEoYsIWul2szN3lmQcYFMjjaZDq2fr9qQ/edit?usp=sharing

      Attachments

        Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. NEXUS-100 org.wildfly.extras.creaper sync to Central

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Done
          is duplicated by

          Feature Request - Feature requests from customers and/or users AEROGEAR-6347 MetricsCollector incorrectly counts serverBatches, so the sending process seem to not have finished

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved
          is related to

          Feature Request - Feature requests from customers and/or users AEROGEAR-6380 WildFly-Swarm launcher (aka fat JARs)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. AEROGEAR-6072 UPS Console shows Pending - because servedVariants < totalVariants

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Bug - A problem that impairs or prevents the functions of the product. AEROGEAR-5832 Introduce Status enum for notification delivery status (VariantMetricInformation/PushMessageInformation)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              Unassigned Unassigned
              lfryc Lukáš Fryč (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 3 hours
                  3h
                  Remaining:
                  Remaining Estimate - 3 hours
                  3h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified