Uploaded image for project: 'AeroGear'
  1. AeroGear
  2. AEROGEAR-4447

Notifier Vertx adapter: removeAllChannels doesn't unsubscribe channels

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 1.1.0
    • None
    • None
    • None

    Description

      The vertx adapter for notifier currently has a removeAllChannels privileged method that is called during subscribe if the reset variable is set to true.

      https://github.com/aerogear/aerogear-js/blob/Notifier-adapters/src/notifier/adapters/vertx.js#L276

      This doesn't actually unsubscribe the channels from the server, just removes them from the channel array.

      https://github.com/aerogear/aerogear-js/blob/Notifier-adapters/src/notifier/adapters/vertx.js#L155

      the stompws adapter doesn't have this method, it actually calls unsubscribe.

      https://github.com/aerogear/aerogear-js/blob/Notifier-adapters/src/notifier/adapters/stompws.js#L221

      i would vote to remove the removeAllChannels method and replace it with how the stompws adapter does it

      Attachments

        Activity

          People

            lholmqui@redhat.com Lucas Holmquist
            lholmqui@redhat.com Lucas Holmquist
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: