Uploaded image for project: 'AeroGear'
  1. AeroGear
  2. AEROGEAR-3999

Push: Constructor of Registrar overhaul

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • 1.2.0
    • 1.2.0
    • push
    • None

      I noticed that the ctor, currently, takes the entire URL of the "registration" endpoint:
      https://github.com/secondsun/PushEEDemo/blob/master/src/com/example/pusheedemo/MainApplication.java#L23

      That's ok, for now. but I think that ideally the application specific part (here "/rest/registry/device") should not be exposed. It could be changed, by PushEE.

      In the iOS SDK, we only "require" the URL + the name of the servlet context.

      For instance:
      https://github.com/aerogear/aerogear-push-ios-registration/blob/master/push-sdkTests/AGDeviceRegistrationSpec.m#L47
      (from a "mocked" test)

      So the SDK internally appends the "rest/registry/device":
      https://github.com/aerogear/aerogear-push-ios-registration/blob/master/push-sdk/AGDeviceRegistration.m#L71

            Unassigned Unassigned
            mwessend@redhat.com Matthias Wessendorf
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: