Details

    • Type: Sub-task
    • Status: Resolved (View Workflow)
    • Priority: Blocker
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.0.0.M2
    • Component/s: examples
    • Labels:
      None

      Description

      If you create a project using the archetype with a "-" or other special characters the table name will be invalid because it using the artifactId to make it unique - see import.sql and member.java

      We need to see if there is a way normalize this - otherwise we need to remove.

        Gliffy Diagrams

          Activity

          jbalunas Jay Balunas created issue -
          jbalunas Jay Balunas made changes -
          Field Original Value New Value
          Priority Critical [ 2 ] Blocker [ 1 ]
          sbs-jira-plugin Jive JIRA Integration made changes -
          Hide
          jbalunas Jay Balunas added a comment -

          qmx - please review this one. If there is a way to get a "normalized" (i.e. non-special character) version of the artifact ID lets use that. Otherwise we need to either add this as a property users should set with creating the projects from the archetype, or just use a static table name based on the archetype - like "MemberPoh5" - and warn about conflicts if more than one version of this is deployed to the same server.

          We'll get this pushed to our repo, then post in the forums where it is. We may even want to consider a special release just for this issue to central - lets discuss in the dev forums once this is fixed in our repo.

          Show
          jbalunas Jay Balunas added a comment - qmx - please review this one. If there is a way to get a "normalized" (i.e. non-special character) version of the artifact ID lets use that. Otherwise we need to either add this as a property users should set with creating the projects from the archetype, or just use a static table name based on the archetype - like "MemberPoh5" - and warn about conflicts if more than one version of this is deployed to the same server. We'll get this pushed to our repo, then post in the forums where it is. We may even want to consider a special release just for this issue to central - lets discuss in the dev forums once this is fixed in our repo.
          jbalunas Jay Balunas made changes -
          Hide
          qmx Douglas Campos added a comment -

          I'll go with the static table name, overridable at generation time

          Show
          qmx Douglas Campos added a comment - I'll go with the static table name, overridable at generation time
          Hide
          qmx Douglas Campos added a comment -

          awaiting review before merging => https://github.com/aerogear/as-archetypes/pull/2

          Show
          qmx Douglas Campos added a comment - awaiting review before merging => https://github.com/aerogear/as-archetypes/pull/2
          Hide
          jbalunas Jay Balunas added a comment -

          When resolving, please update the comment in https://community.jboss.org/docs/DOC-17444 about special characters, and add how to use the snapshot version.

          Show
          jbalunas Jay Balunas added a comment - When resolving, please update the comment in https://community.jboss.org/docs/DOC-17444 about special characters, and add how to use the snapshot version.
          Hide
          qmx Douglas Campos added a comment -

          To use the snapshot version you need to go via File->New->Maven Project, Right?

          Show
          qmx Douglas Campos added a comment - To use the snapshot version you need to go via File->New->Maven Project, Right?
          Hide
          jbalunas Jay Balunas added a comment -

          Two different way. In tools you select the "use snapshots" checkbox. Cli you just put in the snapshot version. We'll need to either have instructions for building it or start to publish to JBoss snapshots repo.

          Show
          jbalunas Jay Balunas added a comment - Two different way. In tools you select the "use snapshots" checkbox. Cli you just put in the snapshot version. We'll need to either have instructions for building it or start to publish to JBoss snapshots repo.
          Hide
          qmx Douglas Campos added a comment -

          I've managed to get it onto tools, it will be like this once we manage to deploy

          https://img.skitch.com/20120206-pftpi1h8wtg1df6q2p21rga88u.jpg

          what are the next steps? will we wait for M2 to deploy it?

          Show
          qmx Douglas Campos added a comment - I've managed to get it onto tools, it will be like this once we manage to deploy https://img.skitch.com/20120206-pftpi1h8wtg1df6q2p21rga88u.jpg what are the next steps? will we wait for M2 to deploy it?
          jbalunas Jay Balunas made changes -
          Assignee Douglas Campos [ qmx ] Jay Balunas [ jbalunas ]
          jbalunas Jay Balunas made changes -
          Parent AEROGEAR-120 [ 12458788 ]
          Issue Type Bug [ 1 ] Sub-task [ 5 ]
          jbalunas Jay Balunas made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Done [ 1 ]
          velias Vlastimil Eliáš made changes -
          Workflow jira [ 12481876 ] GIT Pull Request workflow [ 12483411 ]

            People

            • Assignee:
              jbalunas Jay Balunas
              Reporter:
              jbalunas Jay Balunas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development