"Failed to add deployable jar" error displayed when deploying non-jar files

JARDeployer prints out a confusing warning when a junk file (e.g. .sql script) gets deployed by mistake in the deploy path. This tends to confuse QA and other engineers not familiar with JBoss.

1. Should display the file being deployed, not the copy path.

2. Should be more intelligent and if a ZipException occurs, maybe print out a helpful message saying that this file may not be a .jar file.

"Could not deploy file: file:/home/larry/dev/mqube/servers/jboss-4.0.3/server/default/deploy/foo.sql – Does not appear to be a .jar file or know service: java.util.zip.ZipException: error in opening zip file"

3. Move the stack trace to DEBUG to scare people less.

4. "Failed" seems to indicate something's wrong with the server, not the inputs.

2006-01-25 16:47:19,645 WARN [JARDeployer] ( ) Failed to add deployable jar: file:/home/larry/dev/mqube/servers/jboss-4.0.3/server/default/tmp/deploy/tmp28691foo.sql
java.util.zip.ZipException: error in opening zip file
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:112)
at java.util.jar.JarFile.<init>(JarFile.java:127)
at java.util.jar.JarFile.<init>(JarFile.java:65)
at org.jboss.deployment.SubDeployerSupport.processNestedDeployments(SubDeployerSupport.java:241)
at org.jboss.deployment.SubDeployerSupport.init(SubDeployerSupport.java:139)
at org.jboss.deployment.MainDeployer.init(MainDeployer.java:700)
at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:635)
at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:608)

./src/main/org/jboss/deployment/SubDeployerSupport.java
try

{ // Obtain a jar url for the nested jar URL nestedURL = JarUtils.extractNestedJar(di.localUrl, this.tempDeployDir); JarFile jarFile = new JarFile(nestedURL.getFile()); addDeployableJar(di, jarFile); }

catch (Exception e)
{
log.warn("Failed to add deployable jar: " + di.localUrl, e);